Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YT embed block and auto blocking #170

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Add YT embed block and auto blocking #170

merged 5 commits into from
Dec 1, 2023

Conversation

rrusher
Copy link
Collaborator

@rrusher rrusher commented Nov 2, 2023 •
edited
Loading

@rrusher rrusher self-assigned this Nov 2, 2023
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 2, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 2, 2023

Page Scores Audits Google
/drafts/rrusher/light-youtube Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 2, 2023

Page Scores Audits Google
/drafts/rrusher/light-youtube Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI

@rrusher rrusher requested a review from bstopp November 7, 2023 23:19
@rrusher rrusher marked this pull request as ready for review November 8, 2023 00:36
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 8, 2023

Page Scores Audits Google
/drafts/rrusher/light-youtube Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 29, 2023

Page Scores Audits Google
/careers Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI
/drafts/rrusher/light-youtube Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 29, 2023

Page Scores Audits Google
/careers PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/drafts/rrusher/light-youtube PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 29, 2023

Page Scores Audits Google
/careers Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI
/drafts/rrusher/light-youtube PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 29, 2023

Page Scores Audits Google
/careers Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI
/drafts/rrusher/light-youtube PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 29, 2023

Page Scores Audits Google
/drafts/rrusher/light-youtube PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/careers PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 30, 2023

Page Scores Audits Google
/drafts/rrusher/light-youtube PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/careers PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@bstopp bstopp merged commit 6964195 into main Dec 1, 2023
2 checks passed
@bstopp bstopp deleted the yt-embed branch December 1, 2023 20:03
badvision pushed a commit that referenced this pull request Jan 10, 2024
@rrusher @bstopp
Add YT embed block and auto blocking (#170)
5832bf1 
* add auto blocking YT and yt embed block

* add import

---------

Co-authored-by: Bryan Stopp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstopp bstopp bstopp approved these changes

Assignees

@rrusher rrusher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embedded Video Block
2 participants
@rrusher @bstopp